Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of deprecation process #514

Merged
merged 7 commits into from
Nov 16, 2023
Merged

Conversation

benjagm
Copy link
Collaborator

@benjagm benjagm commented Oct 30, 2023

This is the Initial version of a deprecation process to better handle deprecations.

Summary: In #493 we agreed on preparing a deprecation process to communicate the deprecation of the http://json-schema.org/schema redirect. This is a first proposal to have an standard process for cases like this.

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

Initial version of deprecation process
Julian added a commit to json-schema-org/website that referenced this pull request Nov 3, 2023
Fixes a few 404s, specifically on the Glossary page.

This does not update the pages/blog/posts/website-analytics-snapshot-2023.md
2023 blog post (which directly links to the json-schema-org.github.io
source repository and references behavior that isn't the case for the
new website). json-schema-org/community#514 is relevant here, and should
likely consider what to do with this link and blog text as part of that
PR.

This also does not touch files in the _include directory, which are
submodules included from the spec repo and will have their own PR there.
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the scope of this document? I know the inspiration for it is no longer serving http://json-schema.org/latest, but is this intended to also refer to spec changes? For example, deprecating a keyword? I think that's a different context that would require some different considerations including a much longer deprecation period before removal.

docs/deprecation-plan.md Outdated Show resolved Hide resolved
docs/deprecation-plan.md Outdated Show resolved Hide resolved
benjagm and others added 2 commits November 7, 2023 14:55
Co-authored-by: Jason Desrosiers <[email protected]>
Co-authored-by: Jason Desrosiers <[email protected]>
@benjagm
Copy link
Collaborator Author

benjagm commented Nov 7, 2023

What's the scope of this document?

AS agreed in the last OCWM #515 I'll add a scope section to make it clear that this is not applicable to the spec development.

@jdesrosiers
Copy link
Member

I think my suggestion at the OCWM was misunderstood. I wasn't concerned about non-breaking changes. I'm fine with including that, but that wasn't the point. What I was trying to communicate was that we would want to follow this plan for any breaking changes. Deprecation is just one kind of breaking change. I think it would be wise to change some of the wording in this document so that it generalizes to any breaking change, not just deprecation.

@benjagm
Copy link
Collaborator Author

benjagm commented Nov 9, 2023

I think it would be wise to change some of the wording

You are right @jdesrosiers. I think you didn't said anything about breaking or non-breaking changes, it is just I choose the wrong words to differentiate the new section with the recommendations.

Refer to the plan as breaking changes plan instead of deprecation plan.
@benjagm
Copy link
Collaborator Author

benjagm commented Nov 15, 2023

@jdesrosiers I pushed some changes to improve the wording as we discussed in the last OCWM. Please let me know what do you think about this new version.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is the change I was looking for. There's one place where we probably want to say "change" instead "deprecation" I pointed out inline and we might want to change the filename for the document as well to say "change" instead of "deprecation".

docs/deprecation-plan.md Outdated Show resolved Hide resolved
Co-authored-by: Jason Desrosiers <[email protected]>
@benjagm benjagm merged commit 89e9315 into main Nov 16, 2023
1 check passed
@benjagm benjagm deleted the benjagm-deprecation-plan branch November 16, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants